ach - why we do not put attention to what we are doing???...

 Ach, humans don't want to be fast, they just CTRL+C and CTRL+V, shit over shit, but it is working so what do you want a...!!!

see this snippet:

Is there anything suspicious for you?

NO???
Yesterday I was reading Aaron Stannard blog entry about DRY and above snippet just jumped at me from the corner of my screen.  DRY DRY DRY.

Now: what's wrong with this one?

  • It is not human friendly (formatting)
  • It is not CPU friendly as there are two string interpolations instead of one
  • we could introduce a helper variable to make it nicer to read (and this is a bit of WTF -  see below)
So what we can do with this? Firstly use a single interpolation with a proper formatting like {date:MMM-yy}, this will do the job nicely and we don't need to decipher two statements to get the output when reading the code, now we also could format it a bit, so it is not spread on the wide screen edge to edge...

So what do you think about this:

Looks better? For me this is true, but is this working better? - we will ses in a moment.
I decided also to create something that will be human friendly, run benchmark and WTF...
What was going on under the hood of C# was something that I did not expect. To connected some pieces of string, the compiler is calling string.Concat what means, that calling an abstraction adds compute and memory pressure.

So what is going on here?
Let's see the C# 1.0 syntax for those snippets.

So in my small brain all the circuits are on fire now, as the smallest generated code is the slowest one, as it is calling an abstract function to join/concat  the results.


As we can see on the benchmark results - removing an extra call to format our date is the key for gaining some CPU ticks.


Comments

Post a Comment

Popular posts from this blog

when a new guy joins a team...

Image
Not so long ago, I was browsing merged pull requests to check quality of the work that was done. I don't know why, but in 202X C# is rather a modern language and some language syntax shall be adjusted to newer standards. When I was starting my developer journey - I was told to always add a code that looks similar to the one that already is there, unless it is total crap and adding new stuff needs more effort today, to not to die tomorrow. But in this case, we have a project that is created in in 202X and there is a lot of good looking and working lines of code around, so anyone can follow it. First time, when I was a student and helped my colleague, I was in shock that the teacher recognized my help, I turned all red and asked him "how you were able to recognize that?". He said that most of us have a kind of style that identifies us as developers, so this is spacing, the way how we organize braces (even when autoformated), how we write and solve problems,  and finally var
Read more

FizzBuzz - my first interview task on whiteboard

Image
 I think we all know the FizzBuzz task, when we a function shall print fizz if the number is divided by 3, buzz if by 5 and fizzbuzz when by both. Yesterday I did a small research about how many different implementations we can have using C# and there were many. Ones looks very common with "if"   statement tree, some of them were using LINQ and looking hard to understand what is going on in a first instance. StackOverflow has this one question with a bunch of examples  Writing FizzBuzz , that I will use to check how those solutions work from a performance perspective, code complexity and human understanding. listing 1 fizzbuzz question As we can see, OP introduced a tuple to solve the problem, which in my opinion gives a lot of opportunists for extensions with a little code changes.  The metric looks good, but if we move the list declaration outside the function (so it is not recreated every time the function is called we shall be good) To do benchmark I will convert
Read more

are YOU a garbage collector?

Image
 If I will ask you: "Are you a garbage collector" - I bet I will hear: " NO ", so I ask you: show me your code.... It is unbelievable that so many developers are pushing changes with commented out code, because  there could be a chance to re-use that piece. In fact that time never comes to me and the lines stays there forever. Clean code means no rubbish commented code - we have git to remember that for us. Now, when you need to comment a few lines in a row... there are better solutions, but if someone is lazy and slumsy then we can see diffs on code review like that: Now this is a mystery for me, when I am able to see that this is going to the main branch as the guys who is called code reviewer is there only to click Approve -  I am truly believing that it is not you my reader. I need to admit that, when I was a kid, together with grandma we were collecting garbage as a way to get some $$ for a life and then every piece we found had a material value and were able t
Read more